refactor: establish Media folder feature - #328
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30bae3badc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-media-folder
branch
3 times, most recently
from
August 5, 2026 12:31
9865f4e to
0f9e518
Compare
jderochervlk
force-pushed
the
codex/option5-media-folder
branch
from
August 5, 2026 12:34
0f9e518 to
55fd076
Compare
jderochervlk
force-pushed
the
codex/option5-media-folder
branch
from
August 5, 2026 13:40
55fd076 to
36c4952
Compare
jderochervlk
force-pushed
the
codex/option5-media-folder
branch
from
August 5, 2026 13:57
36c4952 to
890f8c6
Compare
jderochervlk
force-pushed
the
codex/option5-media-folder
branch
from
August 5, 2026 14:00
890f8c6 to
7c72fd8
Compare
jderochervlk
force-pushed
the
codex/option5-media-folder
branch
2 times, most recently
from
August 5, 2026 14:50
589dc61 to
8708e73
Compare
jderochervlk
force-pushed
the
codex/option5-media-folder
branch
2 times, most recently
from
August 5, 2026 15:45
e036246 to
5db376b
Compare
jderochervlk
force-pushed
the
codex/option5-media-folder
branch
from
August 5, 2026 17:40
5db376b to
7a83011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 18 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #327.
Summary
src/mediafolder on the unqualified internalMediafeatureWebAPI.Media -> WebAPI.HTML + MediafeatureBaseEncryptedMediaExtensionsout of the foundational coreMediaError,VideoPlaybackQuality, and the consolidated media interfaces throughWebAPI.MediaTemporary state
Navigatorremains in the legacy DOM folder and references Media-owned types; its broad cross-domain surface is resolved in the later Navigator integration PRDocumentremains in the legacy DOM folder even though it contains Picture-in-Picture operations; it moves with the later Window/document integration layerWebAPI.DOMsource entry remains until its remaining interfaces have been assignedReview focus
WebAPI.Mediadependency closureVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Medianpm run buildnpm testnpm run format:checkgit diff --check